Skip to content

[test only] Run GCP Xlang Dataflow test - #37010

Closed
Abacn wants to merge 2 commits into
apache:masterfrom
Abacn:rv-36654
Closed

[test only] Run GCP Xlang Dataflow test#37010
Abacn wants to merge 2 commits into
apache:masterfrom
Abacn:rv-36654

Conversation

@Abacn

@Abacn Abacn commented Dec 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

investigate #34990

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added the python label Dec 5, 2025
@gemini-code-assist

gemini-code-assist Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is primarily a 'test only' change aimed at triggering a specific GCP Xlang Dataflow test for Python. Concurrently, it removes the Spanner vector store writer module and its associated integration tests from the Beam Python SDK's ML RAG ingestion components. This suggests a cleanup or deprecation of the Spanner integration within the RAG module, possibly as part of a broader refactoring or to streamline the codebase, while also ensuring a critical cross-language Dataflow test is executed.

Highlights

  • CI Test Trigger: The beam_PostCommit_Python_Xlang_Gcp_Dataflow.json configuration file was modified to explicitly include the current pull request number, likely to force the execution of the associated GCP Xlang Dataflow test.
  • Spanner RAG Ingestion Module Removal: The entire spanner.py file, which provided the SpannerVectorWriterConfig and related components for writing vector data to Google Cloud Spanner within Beam's ML RAG ingestion framework, has been removed.
  • Spanner RAG Integration Tests Removal: The corresponding integration tests for the Spanner vector writer, located in spanner_it_test.py, have also been completely removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@Abacn
Abacn marked this pull request as draft December 5, 2025 15:43
@Abacn

Abacn commented Dec 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It might be the conflict of Spanner emulator introduced here:

https://github.com/claudevdm/beam/blob/8f9660483adf5a1ebc6cbb6e45bfeeb09a38f3a4/sdks/python/apache_beam/ml/rag/ingestion/spanner_it_test.py#L76

The environment variable leaked into irrelevant tests trying to use Spanner enumerator but not exist. Testing on reverting the PR

@Abacn Abacn closed this Dec 9, 2025
@Abacn
Abacn deleted the rv-36654 branch December 9, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Abacn